search

miketheprogrammer / go-thrust

Cross Platform UI Kit powered by Blink/V8/Chromium Content Lib
MIT License
445 stars 34 forks source link

Fix to window title and expected behavior of "HasFrame" #79

Closed pathaugen closed 7 years ago

pathaugen commented 8 years ago

Fix to window title and expected behavior of "HasFrame"

  1. Correction to Title to utilize the option.Title instead of spawn.ApplicationName (was incorrectly ignoring the options Title)
  2. "HasFrame" expected behavior fix: 'true' for having a frame and 'false' for not having a frame.
miketheprogrammer commented 7 years ago

Sorry, finally getting around to checking this. Thank you for fixing these oversights and bugs.

miketheprogrammer commented 7 years ago

the comments are ok for now, because the bug was there for so long. At some point the comments should not address the old code, rather only relevant code. Travis is broken but the changes look ok. Will merge.