mikevanwinkle / PyroCMS-Links-Module

http://www.mikevanwinkle.com
7 stars 2 forks source link

Found 1 bug (4x) in 2 files #1

Open biojazzard opened 12 years ago

biojazzard commented 12 years ago

Found 4 times the same bug, it throws the same error:

controllers/admin.php (2x: line 93 & line 138) controllers/admin_groups.php (2x: line 82 & line 140)

Bad:

->append_metadata(js('links.js', 'links'))

Should be:

->append_js('module::links.js')

The module looks great anyway, thanks, great work!

mikevanwinkle commented 12 years ago

Thanks for reporting. What version of PyroCMS are you running ... and what specifically was the error you were getting. I just need to be able to reproduce so I can fix.

shemso commented 12 years ago

i had same issue on PyroCMS 2.1/develop

mikevanwinkle commented 12 years ago

Thanks I'll try with that version.

biojazzard commented 12 years ago

Same for me: 2.1

sorry for the delay... holydays couldn´t wait his time...

mikevanwinkle commented 12 years ago

Ok, sorry, I've been travelling so I haven't gotten to this yet. Will do it this weekend.