Setlist notes and reviews stop rendering on '#' character

mikevoyt / RoboPhish

A Phish music player.

Apache License 2.0

16 stars 8 forks source link

Setlist notes and reviews stop rendering on '#' character #39

Open kevinhaas opened 4 years ago

kevinhaas commented 4 years ago

Interesting issue, but I noticed that some setlist notes and reviews would just cutoff randomly. After looking into it, it was the '#' character causing the issue.

These are older issues, but exactly what I am seeing: https://issuetracker.google.com/issues/36906575#c23 https://issuetracker.google.com/issues/36908740

Stops rendering on apostrophe (\') when it hits the #. No issues with other HTML entities:

mikevoyt commented 4 years ago

Interesting, this doesn't happen to me in the emulator on API28 at 9b8db01f69c055488de7510bfe817dc990b15314:

But I do see it on my phone at API29, so maybe it's a version related issue?

kevinhaas commented 4 years ago

Yea, I'm not sure but it definitely seems like a bug... not sure why it would stop on # in particular.

It's a dirty fix, but I didn't find a real explanation, only a few workarounds. At first I thought it was an encoding issue, but .loadData() with utf-8 set multiple ways didn't work. I still don't fully understand how Android renders this HTML all the way down, so I lack some basic understanding here.

My phone is Android 9(API28?), and the emu I'm using is API29, but I saw it on both.

kevinhaas commented 4 years ago

I'll wait to close until I verify on store.

mikevoyt commented 4 years ago

Ok thanks - I can push out an update within the next day or two (unless anyone has some other changes they would like to get it within the next few days).

kevinhaas commented 3 years ago

@mikevoyt You still around? I opened the app for the first time in a while and saw this stuff was still never pushed to the play store. Looks like the last update was 5/4/20.

mikevoyt commented 3 years ago

@mikevoyt You still around? I opened the app for the first time in a while and saw this stuff was still never pushed to the play store. Looks like the last update was 5/4/20.

Thanks for the reminder @kevinhaas, totally forgot about it - I will plan to push out an update within the next few days.

mikevoyt commented 3 years ago

Hi @kevinhaas sorry for the delay - it looks like your fix was included in the last release - check out the "What's New" section:

fix setlists, thanks to @kevinhaas

https://play.google.com/store/apps/details?id=com.bayapps.android.robophish&hl=en_US&gl=US