Closed burnedfaceless closed 1 year ago
Cool, I'm happy to take a Pull Request. I don't have any way to test Android Auto, but as long as your changes don't break anything else I can take the changes.
-mike
On Wed, Sep 1, 2021 at 6:03 PM Brian Abbott @.***> wrote:
I am an Android user and I have a car that has Android Auto. Every live music app, commercial or not does not support Android Auto.
I am going to go ahead and get this working, and test it. I've only been coding for 3 years seriously and only doing Android 1 of those years. I work a lot and I have been going to a lot of Phish shows but I think I can have it done in a few months if I can put in a few hours a week. Hopefully sooner but I just don't know how much time I can put into this.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mikevoyt/RoboPhish/issues/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5N3HSVAUAZ4CROLYUU23T73EORANCNFSM5DHYNIJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Thanks. Whenever I load the Robophish app it says Error Loading Media. Do I need to obtain a Phish.in API?
Yea if you're building locally you'll need to put the API key in the right place. If you have trouble getting a key and/or not sure where to put it lmk.
-mike
On Thu, Sep 2, 2021 at 11:29 AM Brian Abbott @.***> wrote:
Thanks. Whenever I load the Robophish app it says Error Loading Media. Do I need to obtain a Phish.in API?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mikevoyt/RoboPhish/issues/44#issuecomment-911948583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5N3DAYJEXSGBETQXY2PDT7667FANCNFSM5DHYNIJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
If you could email me a key at burnedfaceless@gmail.com and let me know where to place it that would be great.
It looks like I would put it under buildSrcv inside loadPropertyIntoExtra() with property defaultValue = ""
Is that correct?
I have one more question for you.
I forked the repo to my personal github account. Then I ran checkout to go to the dev branch. Then I used the dev branch to create a branch called android-auto-integration (based off of dev branch).
Is this correct or would you want me to be working in the dev branch on my computer?
You should be able to get your own API key directly from phish.net and/or phish.in pretty easily. I think that's the correct place, I haven't worked on this project in a while but will try to get set up over the weekend to build it again.
Yes submitting a PR to the dev branch from another branch is fine. Thanks!
-mike
On Thu, Sep 2, 2021 at 2:01 PM Brian Abbott @.***> wrote:
I have one more question for you.
I forked the repo to my personal github account. Then I ran checkout to go to the dev branch. Then I used the dev branch to create a branch called android-auto-integration (based off of dev branch).
Is this correct or would you want me to be working in the dev branch on my computer?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mikevoyt/RoboPhish/issues/44#issuecomment-912053367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5N3EXBHCMXBWTINTOGEDT77Q2BANCNFSM5DHYNIJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Sounds good I am in the process of obtaining the API Keys.
Could you tell me where to place them in the project?
Sure, let me take a look this weekend.
On Thu, Sep 2, 2021 at 2:22 PM Brian Abbott @.***> wrote:
Sounds good I am in the process of obtaining the API Keys.
Could you tell me where to place them in the project?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mikevoyt/RoboPhish/issues/44#issuecomment-912067173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5N3CBW6L4VPPCE2P5BKDT77TI7ANCNFSM5DHYNIJA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Mike, I am sorry to be so late but i was in Dver for this past run and I am recovering. The dev for https://Phish.in has a lot of good ideas (like tags) that I would be interested in implementing. It seems like your project hasn't gotten a ton of updates in recenty years. If you can find some more people I will be glad to work on this project.
I'm starting to implement Android Auto and I read that you can test it! So I will send you the docs when it's done and you can see if you're happy with it from a gumpter.
I've also been looking at this meida player and it seems to support assistant. Which that would be fun to integrate.
I'm committed to these pull requests. If you can find others who are willing to take on issues and fix bugs I would ve happy to work on it long term. I'm simply not a good enough programmer to go HAM on this project. I have a ways to go.
On Thu, Sep 2, 2021 at 8:12 PM Brian Abbott @.***> wrote:
Mike, I'm sorry I sent that to you. I meant to send it to creator of Phish.in. It seems like the RoboPhish project hasn't gotten much code written lately and I have been bitten by the bug so I am looking to build something where I can seek out favorite bathtub gins. Phish is my favorite band. I make $19.50 an hour and every single Android app I have created is proprietary so I can't show shit to employers. No degree. I make a little more on W2 stuff but I am going to get involved in open source. I realize it's an undertaking but I really want to build this app by myself before making it public.
On a side note I got the API Keys entered. I hopefully will have this Android Auto up for you sooner than later. I was able to get the icon to show up in my car once I turned on dev mode but it's crashing right now. There's plenty of documentation and I will figure it out.
On Thu, Sep 2, 2021 at 9:01 PM Brian Abbott @.***> wrote:
Hey Mike, I think you've done a cool job with the site and I would like to work with you on an app that contains a lot of the features that you have coded in. We could definitely do tags. I also noticed you can search shows and songs by the highest number of likes. I don't know how your API is set up, but I think it's cool that people could log in (or not) and save good versions of songs or shows for later. If that access could be transferred to the app I think that would be cool. Use the standard API key you gave me for some requests and a JWT (After authentication) for a second API for requests that dealt with a person's liked shows or songs or playlists.
The way the app would work is the local SQLIte db would be the single source of truth. Whenever a screen is requested the DB returns 'live data' and updates the site. Meanwhile the API request is completing and if there are any changes Live Data will automatically update the UI. So you would be able to browse every page you had visited before, but I also would like to allow a user to download shows and songs. And somehow we would need to work that out.
Obviously a lot of kinks need to be worked out. But I think that this would be a cool app.
I am going to be working very hard over the next few months but this is something I would like to talk to you about doing eventually. I have a W2 gig and 2 1099 gigs so it's hard to tell when I will be able to code but I should be able to put in some time soon.
Let me know if this is something you would be interested in doing (I guess you would need to create a second API for user auth). But if we could talk back and forth about what features should be included and how it should function that would be cool.
I'm definitely going to include Android Auto I went to a victim impact panel when I was speeding and I never touch my phone when I drive. That's something every media app should implement.
RoboPhish has been abandonded for a couple of years so after I add FaceID so I can change songs when I drive I would like to start working on something with more features over time.
On Thu, Sep 2, 2021 at 5:07 PM Mike V @.***> wrote:
You should be able to get your own API key directly from phish.net and/or phish.in pretty easily. I think that's the correct place, I haven't worked on this project in a while but will try to get set up over the weekend to build it again.
Yes submitting a PR to the dev branch from another branch is fine. Thanks!
-mike
On Thu, Sep 2, 2021 at 2:01 PM Brian Abbott @.***> wrote:
I have one more question for you.
I forked the repo to my personal github account. Then I ran checkout to go to the dev branch. Then I used the dev branch to create a branch called android-auto-integration (based off of dev branch).
Is this correct or would you want me to be working in the dev branch on my computer?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/mikevoyt/RoboPhish/issues/44#issuecomment-912053367>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAI5N3EXBHCMXBWTINTOGEDT77Q2BANCNFSM5DHYNIJA
. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mikevoyt/RoboPhish/issues/44#issuecomment-912057903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRAXIWVHVYKB3BP4W75FMLT77RS7ANCNFSM5DHYNIJA .
--
Brian Abbott
90 Dover St.
Asheville, NC 28804
912.658.1701
--
Brian Abbott
90 Dover St.
Asheville, NC 28804
912.658.1701
--
Brian Abbott
90 Dover St.
Asheville, NC 28804
912.658.1701
I am an Android user and I have a car that has Android Auto. Every live music app, commercial or not does not support Android Auto.
I am going to go ahead and get this working, and test it. I've only been coding for 3 years seriously and only doing Android 1 of those years. I work a lot and I have been going to a lot of Phish shows but I think I can have it done in a few months if I can put in a few hours a week. Hopefully sooner but I just don't know how much time I can put into this.
edit: can someone assign this issue to me? thanks i'll submit a PR tonight