search

mikeyaworski / Utility-Discord-Bot-Website

Website for interacting with Utility Discord Bot
https://utilitydiscordbot.com
1 stars 1 forks source link

[Movies] Add list virtualization #5

Open mikeyaworski opened 1 month ago

mikeyaworski commented 1 month ago

e108fbab7af21885d55f1e42a2ffd011dbe315a8

mikeyaworski commented 1 month ago

Still need to do virtualization for movies list in autocomplete component, and maybe for movies within a list as well (if it works well with DnD)

mikeyaworski commented 1 month ago

aa7c5ee6d6b5da7b67e5a60514ce7cbf497b9298

mikeyaworski commented 1 month ago

The last remaining part for list virtualization is on the movies List component. It's tricky to get it working properly due to the dynamic heights of the items, in combination with the fact that the list must be drag-and-drop. There is a decent demo for it with virtua here: https://inokawa.github.io/virtua/?path=/story/advanced-with-react-beautiful-dnd--default, but it breaks for items that are not a static height (because the min height style cannot be determined).

WIP branch: https://github.com/mikeyaworski/Utility-Discord-Bot-Website/tree/virtualized-lists

mikeyaworski commented 1 month ago

Consider using other drag-and-drop options as well: https://www.reddit.com/r/reactjs/comments/1eln18p/since_reactbeautifuldnd_is_now_abandoned_which/