mikeymicrophone / commissulator

Commissulator is a set of tools that help Real Estate Agents working with Citi Pads in Manhattan streamline their paperwork.
Other
3 stars 4 forks source link

Embellish urls by setting to_param idioms across multiple resources #11

Open mikeymicrophone opened 5 years ago

mikeymicrophone commented 5 years ago

Commissulator uses default Rails navigation a lot. Simply by defining the method to_param on some of the models, we can begin seeing urls that contain more context. This ticket is pretty easy.

You should look at the data used as the name or reference identifier for the model, and come up with a way to transform it into URL-safe characters. Decide what part of the data would make a good slug, and set it up with some tests to show that no legal configurations are going to result in exceptions.

Not all the models will necessarily need this. In some cases, a nested resource url would be a richer ui.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.025 ETH (5.12 USD @ $204.94/ETH) attached to it.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 months, 2 weeks ago. Please review their action plans below:

1) brascoder has been approved to start work.

Action Plan:

Learn more on the Gitcoin Issue Details page.

mikeymicrophone commented 5 years ago

The test environment is not very developed. I run it by using rspec rather than rake spec. I haven't written any specs on the view or helper layers yet. Not all the specs in there are passing. Let me know if there are any hiccups in getting the tests added and I'll see what I can do to help.

gitcoinbot commented 5 years ago

@brascoder Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

brascoder commented 5 years ago

Submitted WIP

gitcoinbot commented 5 years ago

@brascoder Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@brascoder due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

brascoder commented 5 years ago

@gitcoinbot I've updated the PR

gitcoinbot commented 5 years ago

@brascoder Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

brascoder commented 5 years ago

@mikeymicrophone can you take a look at the updated PR and let me know if that's what you had in mind?

mikeymicrophone commented 5 years ago

Indeed! Sorry about the delay. I'll get this closed out. Thank you very much!

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.025 ETH (4.53 USD @ $181.02/ETH) has been submitted by:

  1. @brascoder

@mikeymicrophone please take a look at the submitted work:


gitcoinbot commented 5 years ago

⚡️ A tip worth 0.00500 ETH (0.9 USD @ $179.88/ETH) has been granted to @brascoder for this issue from @mikeymicrophone. ⚡️

Nice work @brascoder! Your tip has automatically been deposited in the ETH address we have on file.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.025 ETH (4.5 USD @ $179.88/ETH) attached to this issue has been approved & issued to @brascoder.