search

mikeymicrophone / commissulator

Commissulator is a set of tools that help Real Estate Agents working with Citi Pads in Manhattan streamline their paperwork.
Other
3 stars 4 forks source link

Add slugs for model resource urls #33

Closed brascoder closed 5 years ago

brascoder commented 5 years ago

Addresses #11

mikeymicrophone commented 5 years ago

This looks like a good start. Here are a couple questions of style.

Are you comfortable omitting the parentheses? I usually do so as a way of improving readability and encouraging Demeter.

Along those lines, basic_slug could probably be rewritten to use the splat * rather than putting the attributes in an array.

Could it be rewritten so that id didn't have to be explicitly passed?

brascoder commented 5 years ago

@mikeymicrophone let me know if this is more of what you had in mind