search

mikeyy / nonoCAPTCHA

An asynchronized Python library to automate solving ReCAPTCHA v2 using audio
GNU General Public License v3.0
896 stars 196 forks source link

Update pypeteer to 0.0.25 to fix cannot import name 'chromium_executable' #48

Closed parejadan closed 5 years ago

parejadan commented 5 years ago

Problem

capture

craps out due to working with pyppeteer version 0.0.23 which had a typo with for chromium_excutable (missing e between ex and cu). https://github.com/mikeyy/nonoCAPTCHA/blob/master/requirements.txt#L10

Solution

update to pypeteer to version 0.0.25 https://github.com/miyakogi/pyppeteer/commit/6106a6b9c07b7a856505081006cc5746b8cfbeff

Reference

mikeyy commented 5 years ago

Thank you for bringing this to my attention. I've applied the necessary changes in the latest push.

parejadan commented 5 years ago

@mikeyy what's keeping you from just upgrading the pypetteer version to pyppeteer==0.0.25 instead of conforming to the 0.23 typo?

asking because currently trouble shooting env setup on Windows WSL (and maybe using 0.25 is the cause of it).

The only major changes between 0.23 and 0.25 are the typos highlighted on this github issue.

mikeyy commented 5 years ago

@parejadan

Sorry, maybe you've overlooked but this is what I've done.

https://github.com/mikeyy/nonoCAPTCHA/commit/894b89fe55e0e609209db80b92d926f037ad9c03

parejadan commented 5 years ago

yup nvm code looks good. Sorry, similar commit name through mew off

1 2 3

mikeyy commented 5 years ago

That's my mistake, I was lacking any imagination for a new title. Whoops! :)