search

mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
10.84k stars 889 forks source link

No support for ripping discord rips on kemono.party (feature request) #1940

Closed left1000 closed 2 years ago

left1000 commented 2 years ago

There is no support for ripping discord rips on kemono.party, the discord rips on kemono have a weird layout, so maybe this isn't possible?

Just go here https://kemono.party/artists and on the drop down menu for service pick discord.

The weird way all the images fit on one screen with an endless load more button might be what makes it hard? I dunno.

edit: I don't know how to label this a request, sorry.

Copy-link commented 2 years ago

@mikf Could you add the channel names into the metadata?

mikf commented 2 years ago

@ImportTaste https://github.com/mikf/gallery-dl/commit/003f25931d6a07bee6b5e63b82db514c7ed2f603 This also fixes a bug where it would only download from the first channel on a server.

And https://github.com/mikf/gallery-dl/commit/70005e3275272061dfaa9707b8b54d3052f24a2b allows to select which channel to download from by adding #<channel name> to the URL.

Copy-link commented 2 years ago

@ImportTaste 003f259 This also fixes a bug where it would only download from the first channel on a server.

And 70005e3 allows to select which channel to download from by adding #<channel name> to the URL.

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option.

In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

Copy-link commented 2 years ago

@mikf I came across another issue. Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

mikf commented 2 years ago

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option.

In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

fixed in https://github.com/mikf/gallery-dl/commit/bcbf9bcf36e17005613385c2f4db85e71ad19d32

Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

Which server? I'd like to see an example of that but haven't managed to find one myself.

Copy-link commented 2 years ago

Slight issue with the implementation. Since channels can have their content updated in any order, the extractor should treat them similarly to subcategories when it comes to the skip option. In other words, currently, when using a skip option like "abort:1", the extractor stops completely when it hits a filename collision, but the desired behavior would be for it to start checking the next channel.

fixed in bcbf9bc

Some artists just post a cdn.discordapp.com / media.discordapp.net URL in chat, which doesn't embed on the kemono.party website, so gallery-dl isn't currently downloading them.

Which server? I'd like to see an example of that but haven't managed to find one myself.

I posted it here: https://snippet.host/udbq

mikf commented 2 years ago

@ImportTaste https://github.com/mikf/gallery-dl/commit/b6443c576def4c43dec78f1540f3fea68196379c adds "inline" image support.

Copy-link commented 2 years ago

Ran into a small issue. Aside from what I mentioned here https://github.com/mikf/gallery-dl/commit/b6443c576def4c43dec78f1540f3fea68196379c#r58549311, sometimes URLs are surrounded with angle brackets <https://blahblahblah> to keep them from embedding in chat. It seems the extractor is extracting it with the > bracket in the URL.

Copy-link commented 2 years ago

Apparently media.discordapp.net is used for thumbnails and can be replaced with cdn.discordapp.com to retrieve the full size image.

mikf commented 2 years ago

@ImportTaste fixed in https://github.com/mikf/gallery-dl/commit/f1487a3cfa5cb73d71f5fb52e4f5f6809136bf1b. It now detects links to media.discordapp.net and rewrites them to cdn.discordapp.com. Angle brackets and other non-URL characters are now properly excluded.