mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.42k stars 934 forks source link

[exhentai] IndexError: string index out of range #2616

Open thomaslty opened 2 years ago

thomaslty commented 2 years ago

log: [gallery-dl][debug] Starting DownloadJob for 'https://exhentai.org/g/1861972/7770ca480e/' [exhentai][debug] Using ExhentaiGalleryExtractor for 'https://exhentai.org/g/1861972/7770ca480e/' [urllib3.connectionpool][debug] Starting new HTTPS connection (1): exhentai.org:443 [urllib3.connectionpool][debug] https://exhentai.org:443 "GET /g/1861972/7770ca480e/ HTTP/1.1" 200 13165 [exhentai][warning] Enabled Multi-Page Viewer is not supported [exhentai][debug] Sleeping for 4.222 seconds [urllib3.connectionpool][debug] https://exhentai.org:443 "GET /s/af77769347/1861972-1/1861972-1 HTTP/1.1" 200 1630 [exhentai][error] An unexpected error occurred: IndexError - string index out of range. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues . [exhentai][debug] Traceback (most recent call last): File "/usr/local/lib/python3.8/dist-packages/gallery_dl/job.py", line 80, in run for msg in extractor: File "/usr/local/lib/python3.8/dist-packages/gallery_dl/extractor/exhentai.py", line 200, in items data = self.get_metadata(gpage) File "/usr/local/lib/python3.8/dist-packages/gallery_dl/extractor/exhentai.py", line 226, in get_metadata data = self.metadata_from_page(page) File "/usr/local/lib/python3.8/dist-packages/gallery_dl/extractor/exhentai.py", line 258, in metadata_from_page f = data["favorites"][0] IndexError: string index out of range

mikf commented 2 years ago

[exhentai][warning] Enabled Multi-Page Viewer is not supported

That's the problem. You need to disable the mpv feature if you want to download with gallery-dl.

thomaslty commented 2 years ago

disable the mpv feature

how can I disable that?

mikf commented 2 years ago

There's an option field near the bottom of your exh settings: _

On another note: I do not get this particular error for this gallery. For me it fails as expected:

$ gallery-dl https://exhentai.org/g/1861972/7770ca480e/
[exhentai][warning] Enabled Multi-Page Viewer is not supported
[exhentai][error] Failed to extract initial image token
[exhentai][info] No results for https://exhentai.org/g/1861972/7770ca480e/

Do you have any other "special" options enabled that might cause this?

thomaslty commented 2 years ago

I already disabled in the setting as you shown, but it still output the mpv warning. Regarding your failure to download the gallery, it happens on my side too, but it can be opened from browser, strange. Could you please try this url https://exhentai.org/g/1831956/466b17a5ce/ , this time it produce "IndexError: string index out of range" propertly

mikf commented 2 years ago

Could you please try this url https://exhentai.org/g/1831956/466b17a5ce/ ,

# with mpv enabled
$ gallery-dl https://exhentai.org/g/1831956/466b17a5ce/
[exhentai][warning] Enabled Multi-Page Viewer is not supported
[exhentai][error] Failed to extract initial image token
[exhentai][info] No results for https://exhentai.org/g/1831956/466b17a5ce/

# with mpv disabled
$ gallery-dl https://exhentai.org/g/1831956/466b17a5ce/
/tmp/exhentai/[PINK☆DORAGON, Chinjao Gi…Chinese]/1831956_0001_d386d1eda7_000.jpg
/tmp/exhentai/[PINK☆DORAGON, Chinjao Gi…Chinese]/1831956_0002_d4ce0b54fb_001.jpg
^C
KeyboardInterrupt

I should really just add support for downloading with MPV enabled, but anyway: Could you run this URL with --write-pages and upload the generated 01_https_exhentai.org_g_1831956_466b17a5ce_.dump file so that I can see what is different on your end?