mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
12.06k stars 981 forks source link

[exhentai] Skipped files count against image limit #2842

Open God-damnit-all opened 2 years ago

God-damnit-all commented 2 years ago

Even if a file doesn't need to be downloaded, using skip true, it still counts against my image limit. I have original set to true, so that's probably part of it.

mikf commented 2 years ago

To check whether a file already exists in a filesystem, gallery-dl needs its filename extension, and for original files it needs to start the file download to get that, which then counts towards your image limit regardless of whether this file is downloaded or "skipped".

Using a --download-archive would prevent this, since gallery-dl does not have to initialize a network request before being able to check for a file's existence.

God-damnit-all commented 2 years ago

Using a --download-archive would prevent this, since gallery-dl does not have to initialize a network request before being able to check for a file's existence.

Wouldn't I need the exact URLs for that, though? Problem is that, in this instance, there were so many files that I first used one of the torrents available to get the first 2/3 (it had been updated since the initial post) and then I used gallery-dl to get the rest.

Is it possible to check based on the filename of the non-original resolution? Also, I saw in the file listing with the pages that the filenames are in the <img title= tags.

biggestsonicfan commented 1 year ago

Duplicate of https://github.com/mikf/gallery-dl/issues/2603

mikf commented 1 year ago

With the changes in 43d0c49d, this should be fixed for exh since gallery-dl now has the full original filename + extension available without having to start a download.