mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.39k stars 930 forks source link

Please Add Support for yt-dlp use with Instagram #3735

Open cheese529 opened 1 year ago

cheese529 commented 1 year ago

Trying to use yt-dlp to download the videos from instagram so I can do things such as embed metadata, print thumbnail etc. I have pointed gallery-dl towards my yt-dlp config correctly and I have changed my Instagram extractor to support yt-dlp as well but it does not detect it at all.


        "instagram":
        {
        "filename": "{username} {date:%Y-%m-%d} {post_id}_{owner_id}_{num}.{extension}",
            "api": "rest",
            "cookies": null,
            "include": "posts",
            "sleep-request": [6.0, 12.0],
            "videos": "yt-dlp/config",
            "saved": {
                "directory": ["{category}", "Saved"]
            }```
dajotim937 commented 1 year ago

https://github.com/mikf/gallery-dl/blob/master/docs/configuration.rst#extractorinstagramvideos

Where did you find that "videos" field is needed to put yt-dlp config or something. gallery-dl uses yt-dlp automatically if detects yt-dlp.exe

This how you supposed to provide config file: https://github.com/mikf/gallery-dl/issues/3635#issuecomment-1424375773 / https://github.com/mikf/gallery-dl/blob/master/docs/configuration.rst#downloaderytdlconfig-file

cheese529 commented 1 year ago

Where did you find that "videos" field is needed to put yt-dlp config or something.

someone on here mentioned that you need to do change it for the reddit extractor because i was having the same issue trying to download videos from reddit using yt-dlp and they were right, changing the "videos" field to yt-dl fixed that.

also i know how to provide the config file, like i said in my post, i have provided it correctly. here's my full config to make things easier to understand for you https://mega.nz/file/K4c0CJwL#Gr7CT53JV-dqUSpXewhh5hPwyXoF5A6hvflvhFkWAL8

dajotim937 commented 1 year ago

You should clear secrets from deviantart, I think. And double check for any other private values.

Okay, my bad. I have tested some links and you're right. From what I can see, instagram extractor doesn't use yt-dlp or youtube-dl. Sorry for the misunderstanding.

From readme

yt-dlp or youtube-dl: Video downloads

And I thought that gallery-dl uses yt-dlp or youtube-dl for any video downloads.

mikf commented 1 year ago

Related: #2699

And I thought that gallery-dl uses yt-dlp or youtube-dl for any video downloads.

It uses it for some sites, primarily when video and audio are only provided as separate streams.

cheese529 commented 1 year ago

It uses it for some sites, primarily when video and audio are only provided as separate streams.

is this issue also present with reddit because i can't get yt-dlp to work with reddit either, it simply just ignores to follow the commands i put in my yt-dlp config. Related: #3635