mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
10.66k stars 880 forks source link

about favourites #5737

Open Butterfly-Dragon opened 1 week ago

Butterfly-Dragon commented 1 week ago

I just did a huge re-download from my favourite galleries of artists to sort them better (and sent you some 20 EUR because your program saves me a ton of time, enjoy some pizza time!) and also because you tend to actually answer my questions.

So. HEre is one more: i noticed something silly.

If an image was already downloaded because artists favourite each other's image it counts in the "abort:X" number as the source of the "it's already downloaded" is ignored and might lead to termination of a download due to people faving each other stuff in sequence "over the abort limit" before the gallery gets downloaded also that image is now in the wrong folder because if i sort artists folders using the user.... the faves they give each other go in the faving user folder not in the faved user folder.

This behaviour appears to be site-independent, that is: newgrounds deviantart furaffinity and artstation all seem to behave in the same manner.

So i am not sure if i am doing things in the wrong way or if i hit a snag because this is the expected behaviour.

I feel like i am missing something tiny and silly but crucial. 😅

mikf commented 1 week ago

The solution to this is unfortunately not "something tiny and silly", but might require a lot of work instead.

I've recently added a skip-filter option which is meant to select which files are counted towards the abort:N limit, but I don't think there's a usable condition for your problem, so this one's out.

You'll probably have to adjust the target directory favorites get stored in so that each user's favorites get their own directory and therefore don't overlap.

Of course, each site has its own names for "user you download from" and "artist that created this file", so this will probably have to be done 5 times.

For furaffinity, something like this will work. You might also adjust the filenames to include the artist name instead of downloading each artist into a separate directory.

{
    "extractor": {
        "furaffinity": {
            "favorite": {
                "directory": ["{category}", "{user!l}", "favorites", "{artist}"]
            }
        }
    }
}

In case you are using an archive, you'll also have to adjust the archive ID format in a similar way.

and sent you some 20 EUR because your program saves me a ton of time

Thank you.

Butterfly-Dragon commented 1 week ago

for the directory i solved by storing not in user folder but in the artist folder now i have to reread what you wrote there to understand the skip filter as i just woke up. 😅 Still: thank you. 🙇‍♂️