mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
10.66k stars 880 forks source link

pixiv oauth no longer works as of a1bb327 #5757

Closed kattjevfel closed 1 week ago

kattjevfel commented 1 week ago

As of commit a1bb32792b91e03c8440ff4fffdced4fe87f6e6f (bisected), when running gallery-dl oauth:pixiv it will open a browser but then crash, here's the verbose output:

katt@main ~ » gallery-dl --config-ignore oauth:pixiv --verbose
[gallery-dl][debug] Version 1.27.1-dev
[gallery-dl][debug] Python 3.12.4 - Linux-6.9.5-zen1-1-zen-x86_64-with-glibc2.39
[gallery-dl][debug] requests 2.32.3 - urllib3 1.26.18
[gallery-dl][debug] Configuration Files []
[gallery-dl][debug] Starting DownloadJob for 'oauth:pixiv'
[oauth][debug] Using OAuthPixiv for 'oauth:pixiv'
[oauth][info] Opening URL in Firefox:

https://app-api.pixiv.net/web/v1/login?code_challenge=jY1DQlWhBJu6U7knqbXXTutqfuQyG2-T8zBBZEww3_M&code_challenge_method=S256&client=pixiv-android

[oauth][error] An unexpected error occurred: TypeError - 'bool' object is not callable. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[oauth][debug] 
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/gallery_dl/job.py", line 150, in run
    for msg in extractor:
  File "/usr/lib/python3.12/site-packages/gallery_dl/extractor/oauth.py", line 427, in items
    code = self.open(url, params, self._input)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/gallery_dl/extractor/oauth.py", line 92, in open
    return (recv or self.recv)()
           ^^^^^^^^^^^^^^^^^^^^^
TypeError: 'bool' object is not callable
mikf commented 1 week ago

Thanks for reporting. Fixed in 60b454119977391cc0c697625e093a93f006c9e7.