search

mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.93k stars 975 forks source link

[flickr] reference the correct function #6077

Closed Pyker closed 2 months ago

Pyker commented 2 months ago

This PR fixes a bug introduced in https://github.com/mikf/gallery-dl/commit/e92a9ae34389bb1d429b75ee981dde770b962b36#diff-5741d04464e95eab8716d83190078fd31be0ad91fed8da24cd390b9447239d35R522.

Before the referenced commit, the code read photo.update(self.api.photos_getAllContexts(self.item_id)). After the commit, the code became the same (see how the EXIF-related code above was updated correctly), referencing self.api, which doesn't exist in this new context, which completely breaks this functionality since that exception will always become a warning, when it really should've been caught while reviewing the changes: image

Pyker commented 2 months ago

I honestly couldn't figure out how to name this commit, so I welcome any suggestions.

mikf commented 2 months ago

Thank you very much for catching and even fixing this.