mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.7k stars 953 forks source link

[Patreon] Gallery-dl no longer seeing attachments #6268

Closed biggestsonicfan closed 3 weeks ago

biggestsonicfan commented 3 weeks ago

Noticed this a few days ago but didn't think anything of it, but I believe the the way to grab attached files from patreon isn't working anymore. Was there a config change at some point?

mikf commented 3 weeks ago

I think this was already reported by https://github.com/mikf/gallery-dl/issues/6241#issuecomment-2386343160 yesterday and should be fixed in https://github.com/mikf/gallery-dl/commit/fb6be2dd3444c3b4b0b9d1dd924bf1530f3dc0d0.

Patreon split its attachment data into attachments and attachments_media, and gallery-dl considered only files from attachments.

biggestsonicfan commented 3 weeks ago

Interesting, I updated to latest git before posting the issue, so I thought it was still there. Just ran the update again via python3 -m pip install --force-reinstall --no-deps --no-cache-dir https://github.com/mikf/gallery-dl/archive/master.tar.gz --break-system-packages (--break-system-packages required for linux distros which now use python dependencies as packages), but I just ran it again and well, now it works. It missed I think 2 attachments from patrons I am no longer subscribed to but that's fine, glad to see it's working!

biggestsonicfan commented 3 weeks ago

I spoke way too soon. Attempting to download via gallery-dl patreon.com/home still fails to grab attachments, my usual go-to for downloading who I'm subscribed to.

mikf commented 3 weeks ago

I forgot that attachments_media needs to be requested explicitly for everything that is not a single post. Should be fixed for all Patreon results this time. (https://github.com/mikf/gallery-dl/commit/aa31c153e389dc0fc3063a7483d6e16ce7d1cf31)

biggestsonicfan commented 3 weeks ago

Oh wow, picking up a lot of content that was missed, good stuff, thank you!