search

mikf / gallery-dl

Command-line program to download image galleries and collections from several image hosting sites
GNU General Public License v2.0
11.7k stars 953 forks source link

Danbooru issue #82

Closed yomanbest closed 6 years ago

yomanbest commented 6 years ago

Lately I have not been able to download any full danbooru tag galleries because of a really weird error. It downloads, I'd say, about the first page then this happens 

[danbooru][debug] Traceback
Traceback (most recent call last):
  File "c:\users\alpha\appdata\local\programs\python\python36-32\lib\site-packages\gallery_dl\job.py", line 63, in run
    for msg in self.extractor:
  File "c:\users\alpha\appdata\local\programs\python\python36-32\lib\site-packages\gallery_dl\extractor\booru.py", line 63, in items
    self.update_page(data)
  File "c:\users\alpha\appdata\local\programs\python\python36-32\lib\site-packages\gallery_dl\extractor\booru.py", line 95, in update_page
    self.params["page"] = "b{}".format(data["id"])
KeyError: 'id'

Am I doing something wrong? The downloader was working fine so far.

mikf commented 6 years ago

Thanks for reporting this.

This bug was introduced in v1.3.0 (commit 5008e10) and effects konachan, yandere and e621 as well. I changed some variable-names around and forgot to change one of them, which caused the page-updating function to get the wrong dictionary without any id in it.