search

mikhail-angelov / shared-notes

MIT License
5 stars 0 forks source link

Relative path to the current directory #2

Open jtd-n opened 1 year ago

jtd-n commented 1 year ago

Thanks for extension! Is it possible to add a relative path to the current directory in SharedNotes.rootFolder? For portability, this is very lacking.

mikhail-angelov commented 1 year ago

sure, you can do it outside of this extension, create sub directory in your root folder and create files there it will work

jtd-n commented 1 year ago

Let's say the notes are in full path "d:\VSCode\data\notes". In the parameter SharedNotes.rootFolder I put "data\notes" and the notes are really visible in list, but they do not open!! But if change the full path then everything works!

And there is still a problem, when you rename a note, the last line with the text is erased !!

mikhail-angelov commented 1 year ago

Let's say the notes are in full path "d:\VSCode\data\notes". In the parameter SharedNotes.rootFolder I put "data\notes" and the notes are really visible in list, but they do not open!! But if change the full path then everything works!

I see it does not make sense for me to support relative path like this "data\notes" in this case I cannot controll parent folder, so please do not use it, use absolute path (or sim link if you like)

And there is still a problem, when you rename a note, the last line with the text is erased !!

I do not manage to reproduce it on mac, maybe it OS specific, I open for PRs