miki151 / keeperrl

Source code of KeeperRL
GNU General Public License v2.0
875 stars 109 forks source link

consider adding effect "removecompanion" #2013

Open samuellsk opened 1 year ago

samuellsk commented 1 year ago

the opossite to the already implemented effect "addcompanion"

so it will gonna remove the defined companion from the list.

i can imagine it being either used in buffs or in spells (for example mount / dismount) could add steed companion / remove them if not required so the player can mount it in adventurer mode

miki151 commented 1 year ago

I can add it if you need it in your mod, I don't have much use for it myself.

samuellsk commented 1 year ago

I can add it if you need it in your mod, I don't have much use for it myself.

Idea struck me with a "replace". As your minion / keeper will train. You can remove his companions and add stronger ones. An Elementalist is being hardly used by anyone would be good example for this. If you capture him , convert him he could train and potentialy become more powerful / attractive to player

Well at some point i wanted to create adventurer buying a horse...or another type of mount, but that being done with filters / summoned creature...etc a little horrible goal to achieve. The most simpliest way would be to have addcompanion, than i realized there is no way to remove that companion if you need to "unsummon" him :)

miki151 commented 1 year ago

The problem with companions is that they respawn, so it would be a bit unrealistic for buying horses.

samuellsk commented 1 year ago

The problem with companions is that they respawn, so it would be a bit unrealistic for buying horses.

Well, he would "buy" spell , that would be seting a flag and using addcompanion (so that you cant add multiple copanions) than since its a companion you can mount it, but you cannot "dissmiss" it...

Anyway, i guess just close it. Was worth a shot :)

samuellsk commented 11 months ago

this could be usefull for oher thinkg like buff (from equipment) if you wear a staff of shamans it would give you companions, if you take it off, well they will dissapear....

also can be used for the buff that will be applied through glyph... there are a lot of posibilities how it could be utiliez , please reconsider it.