mikibonacci / aiidalab-qe-vibroscopy

MIT License
1 stars 1 forks source link

Results panel functionalities and more #1

Open mikibonacci opened 1 year ago

mikibonacci commented 1 year ago

Less critical - no real issues -:

AndresOrtegaGuerrero commented 12 months ago

for the interactive raman, the user should also have the option to get the single crystal spectra from run_single_crystal_raman_intensities (this should let the user to specify the polarizability vector incoming,outgoing) or powder

AndresOrtegaGuerrero commented 10 months ago

@mikibonacci for the Raman and Ir, that something is different i think you mean about this , if self.inputs.property in ('ir', 'nac', 'born-charges', 'bec', 'dielectric'): self.ctx.numbers, self.ctx.signs = get_irreducible_numbers_and_signs(preprocess_data, 3) elif self.inputs.property in ('raman', 'susceptibility-derivative', 'non-linear-susceptibility'): self.ctx.numbers, self.ctx.signs = get_irreducible_numbers_and_signs(preprocess_data, 6) ,

in the dielectric workchain i guess ?

mikibonacci commented 10 months ago

@AndresOrtegaGuerrero exactly, essentially the order of the correction to the force constants, If I am correct... sorry, I had not time to check better.

But I see that in the first case (preprocess_data, 3), you add second derivative correction, in the latter you provide third derivative... So in principle the effect (the pyhisics) is different.

I think that this is not seen by the post process utility, so you can access both spectra, even if one of them is not accurate.

What do you think? It is bad that we cannot have both at the same time, but maybe something can be done at the VibroWorkChain level.