search

mikibonacci / aiidalab-qe-vibroscopy

MIT License
1 stars 1 forks source link

Inelastic neutron scattering (INS) panel in results #62

Closed mikibonacci closed 3 months ago

mikibonacci commented 3 months ago

This will add the INS panel in the results. Also, in the repository, I put a notebook (aiidalab_qe_vibroscopy/utils/euphonic/Detached_app.ipynb) which basically allows to plot INS data if we have phonopy.yaml and force_constanst.hdf5 files. the python widgets are the same, so the code to be maintained is only one.

mikibonacci commented 3 months ago

Probably, instead of merge, we can do a Squash, and I will take care of resuming the main things I committed

AndresOrtegaGuerrero commented 3 months ago

should we merge it ?

mikibonacci commented 3 months ago

I just need to complete your suggestions (btw, thanks) and then I will merge it!

mikibonacci commented 3 months ago

@AndresOrtegaGuerrero , I just merged the PR, adding also your suggestions. Thanks a lot!