search

mikifus / padland

Padland is a tool to manage, share, remember and read collaborative documents based on the Etherpad technology in Android.
Apache License 2.0
62 stars 15 forks source link

Requirement on the READ_PHONE_STATE permission #12

Closed akien-mga closed 8 years ago

akien-mga commented 8 years ago

Hi there,

I just discovered your interesting app on F-Droid, being a pad junkie myself I'm looking forward to trying it.

When trying to install it though I was a bit puzzled to see that it asks for access to the phone state and identity (android.permission.READ_PHONE_STATE, https://github.com/mikifus/padland/blob/master/app/src/main/AndroidManifest.xml#L14). It also asks for access to the SD card contents and network connection, but those two sound pretty normal for the app's purpose.

I'm a bit touchy about what applications want to access from my personal data, and I'm not sure to understand why knowing the phone state and identity would be relevant. Could you clarify the situation?

Thanks in advance.

Edit: I checked the git history and apparently it has always been required: https://github.com/mikifus/padland/blob/565a289d06380baaa107e33b5b1c45c73a712d58/app/src/main/AndroidManifest.xml#L13

mikifus commented 8 years ago

You are absolutely right.

Back then READ_PHONE_STATE was needed for some basic functions. It is not the case anymore.

The WRITE_EXTERNAL_STORAGE was added for storing data in locally. But I decided to go on with SQL for the very same reason of user safety. It must be removed as well.

Thanks for checking. I will include these changes in the next release.

mikifus commented 8 years ago

This has been fixed in the lastest version.

akien-mga commented 8 years ago

Confirmed, I just installed it from F-droid :)