search

mikifus / padland

Padland is a tool to manage, share, remember and read collaborative documents based on the Etherpad technology in Android.
Apache License 2.0
62 stars 15 forks source link

"onReceivedError" does not execute in API level < 23. #47

Closed strooonger closed 6 years ago

strooonger commented 6 years ago

Hi,

I found that you have used onReceivedError(WebView view, WebResourceRequest request, WebResourceError error) in PadViewActivity, which is added in API level 23. However, it does not exist in API level < 22, meaning that the code logic you wrote to handle webview error will not take effect. (See this link)

To fix this issue, add deprecated onReceivedError (WebView view, int errorCode, String description, String failingUrl) to make it compatible for API level < 22.

Thanks.

mikifus commented 6 years ago

Thanks, will be fixed in the next version.