search

mikifus / padland

Padland is a tool to manage, share, remember and read collaborative documents based on the Etherpad technology in Android.
Apache License 2.0
62 stars 15 forks source link

Refactor Member Ignoring Method smell in PadlistDb class #55

Closed emaiannone closed 4 years ago

emaiannone commented 4 years ago

Hi, I'm Emanuele Iannone, a master student at University of Salerno. Since my bachelor's thesis I have been working on a code smell refactoring plugin called aDoctor, which is able to identify and fix energy-related problems in Android apps. I launched it on your project, finding different instances of code smells. I chose one of them and let the plugin automatically fix it. In this case I chose Member Ignoring Method, that is present when a non static method does not use at all instance variables and other non static methods. These kind of smell may have a non trivial impact on energy consumption, as shown in this paper: https://www.sciencedirect.com/science/article/pii/S0950584918301678. Besides, this kind of refactoring does not impact on the functionalities of your app, so it is totally safe. Let me know if you are interested in this refactoring proposal.

mikifus commented 4 years ago

Hi,

I'm glad my only code smell detected was just a static declaration. Unfortunatelly, I can't merge this as this change is breaking with the next message:

Inner classes cannot have static declaration

Thanks. Your plugin looks good.

emaiannone commented 4 years ago

Thank you @mikifus I understand this bug and I will fix it as soon as possible!