Pausing in fullscreen causes the video to move down

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Run a video on fullscreen
2. Pause the video
3. Play the video (the video will now move down about the same height as the 
OSD)

What is the expected output? What do you see instead?
Expected: to see the video stay where it is
What happens: it moves down (and gets worse depending on how many times you 
pause&play)

What version of the product are you using? On what operating system?
Gnome-mplayer 1.0.7 on Archlinux with awesome 3.5 as my WM.
It gives the same results with xcompmgr running and when it isn't.

Please provide any additional information below.
Other video outputs like xv, gl, etc give the same result.
Switching out from fullscreen and back into fullscreen resets the video to 
where it should be.

Disabling/Enabling the fullscreen control bar animation has no effect.

Disabling the control bar (OSD) fixes this behaviour, but there's no option to 
disable it permanently which makes this a bit annoying.
Either I have to hit F twice after pausing to fix the video or I have to hit C 
at the start to disable the control bar.

Original issue reported on code.google.com by arno...@gmail.com on 7 Jan 2013 at 8:45

Attachments:

• gnome-mplayer.log
• 2013-01-07_21-31-34.png
• 2013-01-07_21-31-37.png
• 2013-01-07_21-31-38.png
• 2013-01-07_21-31-46.png

[GoogleCodeExporter]

If you switch window managers does the problem go away? I believe their might 
be an issue with awesome and a gtk window of type GTK_WINDOW_POPUP, which are 
used in that scenario. I do not see this issue in metacity, gnome-shell, or 
cinnamon.

Original comment by kdeko...@gmail.com on 10 Jan 2013 at 1:00

[GoogleCodeExporter]

Ah, can't believe I didn't think of testing other WMs.
I tried with openbox since it added the least extra clutter to my install.
The problem is indeed not present there, so it seems to be an issue with 
awesome wm.

Original comment by arno...@gmail.com on 10 Jan 2013 at 2:08

[GoogleCodeExporter]

Reported this issue on the awesome bug tracker.
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1092

Original comment by arno...@gmail.com on 10 Jan 2013 at 1:56

[GoogleCodeExporter]

Original comment by kdeko...@gmail.com on 21 Mar 2013 at 2:11

• Changed state: WontFix

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This is also happening to me on XMonad. It seems the issue is these tiling 
window managers don't really have real fullscreen. The fullscreen window grows 
vertically every time you pause/unpause and since it's not rigid the window 
manager actually lets it do it.

Original comment by k...@void.im on 11 Apr 2013 at 9:23

[GoogleCodeExporter]

The problem seems to be in set_media_label under gui.c since removing line 7150 
(g_idle_add(set_media_label, idledata);) from gui.c fixes the problem.

Original comment by k...@void.im on 11 Apr 2013 at 10:34

[GoogleCodeExporter]

Does changing that line from

            g_idle_add(set_media_label, idledata);

to

        if (!fullscreen) g_idle_add(set_media_label, idledata);

solve it?

Original comment by kdeko...@gmail.com on 11 Apr 2013 at 11:03

[GoogleCodeExporter]

I changed line 645 in gui.c right after if(showcontrols):

total_height += alloc.height; 

to

if (!fullscreen)total_height += alloc.height;

and that seems to solve it. I'm guessing it was adding the height of the 
control box when it shouldn't since it's a float? (I've never worked with GTK 
so the code's a bit confusing to me)

Original comment by k...@void.im on 11 Apr 2013 at 11:07

[GoogleCodeExporter]

Here's a patch for the above

Original comment by k...@void.im on 13 Apr 2013 at 3:20

Attachments:

• fix_fullscreen.diff

[GoogleCodeExporter]

Patch Applied to SVN, thanks!

Original comment by kdeko...@gmail.com on 13 Apr 2013 at 1:17

• Changed state: Fixed