search

mikitex70 / plantuml-markdown

PlantUML plugin for Python-Markdown
BSD 2-Clause "Simplified" License
192 stars 55 forks source link

remove self param from static method, diable image renaming/removing #1

Closed howaryoo closed 7 years ago

howaryoo commented 9 years ago

Hi, thanks for the tool! I use it along with https://github.com/adamzap/landslide . I had to make these changes to make it work though.

mikitex70 commented 9 years ago

Thanks howaryoo for your patch. I've only one question before merging it: what's the behaviour if case there is more than one UML diagram in the same markdown file? I think will be keept only the last diagram.

howaryoo commented 9 years ago

Hi Michele, my quickfix supports multiple diagrams in one markdown file. (I did not write a unit test but I tried with two). Regarding merging, the best would be to fix your implementation, It seems that your are not using the same name to write and then to read the images, I would be glad to take a deeper look but that might be not immediate and push to the same PR. Regards, Arye

On Sat, Apr 4, 2015 at 6:02 PM, Michele Tessaro notifications@github.com wrote:

Thanks howaryoo for your patch. I've only one question before merging it: what's the behaviour if case there is more than one UML diagram in the same markdown file? I think will be keept only the last diagram.

— Reply to this email directly or view it on GitHub https://github.com/mikitex70/plantuml-markdown/pull/1#issuecomment-89591627 .

mikitex70 commented 7 years ago

Hi howaryoo, sorry for the long delay before to accept you contribute. I've restored part of your patch, specifically the renaming image part; now it is used as a kind of caching, avoiding to re-generate diagrams that aren't changed. I'hope this versions works fine for you