mikitex70 / plantuml-markdown

PlantUML plugin for Python-Markdown
BSD 2-Clause "Simplified" License
192 stars 55 forks source link

Fix an error with svg format #5

Closed miyajan closed 7 years ago

miyajan commented 7 years ago

Fix an error with SVG format and python3.

The deleted line causes an error like the following.

TypeError: cannot use a string pattern on a bytes-like object

And the replacement seems not to be necessary with the latest PlantUML, 1.2017.13.

mikitex70 commented 7 years ago

I remember that I've added that regular expression to remove the first line of the SVG (the <?xml ...> line) because a browser wasn't handling correctly the rendering, but I don't remember which browser (maybe an old version of Intenet Explorer). The patch looks good for me, and the generated HTML renders ok in all my browsers (not tested with IE). Thanks miyajan.