mikitex70 / plantuml-markdown

PlantUML plugin for Python-Markdown
BSD 2-Clause "Simplified" License
192 stars 55 forks source link

Config value: 'markdown_extensions'. Error: extendMarkdown() missing 1 required positional argument: 'md_globals' #67

Closed mriedem closed 1 year ago

mriedem commented 1 year ago

The 3.4 release of Markdown dropped the md_globals kwarg used here:

https://github.com/mikitex70/plantuml-markdown/blob/e264c85c738ff4390f412b2dff488f717025f9c3/plantuml_markdown.py#L349

Which results in an error.

We're using plantuml_markdown-3.5.3.

mriedem commented 1 year ago

Here was the deprecation notice: https://github.com/Python-Markdown/markdown/blob/a11431539d08e14b0bd821ceb101fa59d6a74c8a/docs/change_log/release-3.0.md#md_globals-keyword-deprecated-from-extension-api

oprypin commented 1 year ago

Could you include this solution into a new release? Otherwise this problem will keep having new occurrences for people

mikitex70 commented 1 year ago

Released version 3.6.0 with this fix and some other enhancement.