mikitex70 / redmine_drawio

Macro plugin to embed draw.io diagrams into Redmine wiki pages
MIT License
123 stars 51 forks source link

Redmine 5.x issue #112

Closed whotopia closed 2 years ago

whotopia commented 2 years ago

Have tried to add a simple

{{drawio_attach(myDiagram)}}

to Redmine 5.x wiki.

To this I get the error:

Error executing the drawio_attach macro (undefined methodstrip_non_filename_chars' for #) ` in red on the wiki page.

Can someone help?

mikitex70 commented 2 years ago

Hi @whotopia, I'll check the sources, maybe during the port on Redmine 5 I missed something.

mikitex70 commented 2 years ago

I've done a quick test and the macro drawio_attach seems working fine, and the usages of strip_non_filename_chars are correctly fixed for Redmine 5. Are you sure that the sources of the plugin are correct? Can you try to re-download the plugin again?

whotopia commented 2 years ago

I've done a quick test and the macro drawio_attach seems working fine, and the usages of strip_non_filename_chars are correctly fixed for Redmine 5. Are you sure that the sources of the plugin are correct? Can you try to re-download the plugin again?

It is weird. So I downloaded your redmine_drawio-1.4.0.tar.gz release file, deployed, and that one works fine. I'm relieved for this, but will do a bit more digging on a non-production system. Might it be an interaction with another plugin? I'll let you know. For now closing this.