search

mikitex70 / redmine_drawio

Macro plugin to embed draw.io diagrams into Redmine wiki pages
MIT License
125 stars 51 forks source link

Bug fix/missing common mark support #124

Closed liaham closed 1 year ago

liaham commented 1 year ago

Hi @mikitex70,

I tested redmine_drawio with common mark editor but missed the drawio wikitool bar buttons.

The problem is solved by adding your 'common_mark_helper.rb' to 'lib/redmine_drawio.rb'. Additionally, I fixed some tests to be compatible with Ruby 3.x and 2.7.x.

Best Regards, @liaham

mikitex70 commented 1 year ago

Hi @liaham, thank you for your great work. PR merged, I will release it on the weekend.

liaham commented 1 year ago

Thank you, its always a pleasure to contribute! :)