search

mikitex70 / redmine_drawio

Macro plugin to embed draw.io diagrams into Redmine wiki pages
MIT License
121 stars 51 forks source link

Support *.drawio file ending #131

Closed liaham closed 8 months ago

liaham commented 10 months ago

Hi @mikitex70,

I recently found out that it is possible to integrate outside of Redmine created drawio files into Redmine with your plugin. For doing so, you need to rename the file with *.drawio ending to *.xml. It will be identified and you can continue to draw your items.

Unfortunately, it is not possible to initially save drawio files as *.xml. When I chose this ending the file will be listed with *.dawio ending nevertheless. I need to change the file ending manually in a second step.

Do you think it is possible to support *.drawio file endings in your plugin?

Then it would be much easier to integrate existing drawio files in Redmine.

Best Regards, @liaham

mikitex70 commented 10 months ago

Hi @liaham, in the develop branch I pushed a preliminary version that implements your request. Now the drawio extension in allowed, and when creating a new diagram the diagram typeDRAWIO is available. I'm not sure about this new option, maybe it's better to handle the drawio extension internally, adding the extension to the filename only if it's not xml nor drawio. What do you think about?

liaham commented 10 months ago

Hi @mikitex70,

I am happy to see that you have been started with this feature. Thank you! :)

I would prefer the drawio extension as a further option as you implemented in your preliminary version. This would make it more transparent for a user about what is supported and what not.

I tested the preliminary version with these workflows:

drawio_attach macro

✅ Upload drawio file on wiki page. ✅ Click wikitoolbar icon for drawio_attach macro. ✅ Select drawio file ending, enter file name and other options. ✅ Save wiki page. ✅ Open integrated drawing, change it and save. ✅ See changes on wiki page. ❌ Download changed file. ❗<-- Is not working right now since there won't be a new file version saved when saving changes in drawio UI.

drawio_dmsf macro

✅ Upload drawio file in dms of the current project. ✅ Navigate to wiki page in the same project and click wikitoolbar icon for drawio_dmsf macro. ✅ Select drawio file ending, enter file name and other options. ✅ Save wiki page. ❌ Open integrated drawing, change it and save. ❗<-- Not possible since wiki page shows macro error with (wrong number of arguments (given 1, expected 0)). ❌ See changes on wiki page. ❌ Download changed file.

Let me know when there is something else I can help with!

Best Regards, @liaham

mikitex70 commented 10 months ago

Try the new version from the develop branch, I hope I have solved all the problems.

liaham commented 9 months ago

I did have a look at the code and needed to fix a further problem w.r.t. dms plugin. I will prepare a PR when I have added some more tests. This can take a little while until I can proceed. I think 1-2 weeks.

Only wanted to let you know! :)

mikitex70 commented 8 months ago

Released in version @v1.4.8@. Thanks for your work.