search

mikitex70 / redmine_drawio

Macro plugin to embed draw.io diagrams into Redmine wiki pages
MIT License
125 stars 51 forks source link

Removes mathjax loading from cdn #138

Closed liaham closed 1 week ago

liaham commented 1 week ago

Since drawio version 10.7.4 (03-JUN-2019) mathjax codebase is included in drawio/src/main/webapp/math directory.

redmine_drawio_mathjax

There is no need to double include mathjax via this plugin anymore. Therefore, I removed the cdn loading making it also more secure due to possible Cross-Site Scripting vulnerabilities in hostet libraries on cdnjs.cloudflare.com.

I would appreciate it if you could merge this patch, assuming there are no objections.

liaham commented 1 week ago

Hi @mikitex70,

this commit 8c9bc49 was not intended to be submitted. Let me know when you won't remove it by your self. I will recreate the PR without it.

Best Regards, @liaham

mikitex70 commented 1 week ago

Hi @liaham, thank you for your work. I will make a new version soon.

liaham commented 1 week ago

Great!

I am currently preparing a new feature supporting the various drawio UI (https://www.drawio.com/blog/diagram-editor-theme) as user preference.

Moreover, the plugin is not compatible with Redmine 6. I would fix that too.

Do you think the drawio UI feature should be released with Redmine 6 compatability or as an extra feature release before?

mikitex70 commented 1 week ago

It would be better to separate the features, so that we can distinguish what belongs to UI improvement and what belongs to Redmine 6 support (I discovered the new version today). Thank you for your work, always very neat. I don't have much time to work on this plugin, and moreover my company is thinking of switching from Redmine to Jira, so I feel even less motivated.

liaham commented 1 week ago

I agree with you. I will push the UI feature soon. Then you can add it to the new release after review.