Fixing for Rml 5.* releases Vulkan issue

mikke89 / RmlUi

RmlUi - The HTML/CSS User Interface library evolved

https://mikke89.github.io/RmlUiDoc/

MIT License

2.57k stars 295 forks source link

Fixing for Rml 5.* releases Vulkan issue #601

Closed wh1t3lord closed 3 months ago

wh1t3lord commented 3 months ago

Ancient issue, because first mentioned by @Thalhammer (see https://github.com/mikke89/RmlUi/pull/430).

Example demonstation of bug:

bug

The fix is really straightforward and I forgot why I keep incorrect usage of semaphores for queue submit, but I didn't forget about that issue after 2 years...

I would like to call @Thalhammer for testing in his environment and report that there's no any issues too.

mikke89 commented 3 months ago

Thanks for the fix! This looks good to me, I'll wait a bit to see if anyone else has any input. The commit history is very noisy, but I can always squash merge it.

Thalhammer commented 3 months ago

Hi, thanks for the headsup. Sadly I can't help with testing because I no longer work on the project. I could check out the project on my private Linux PC, but it's obviously not the same. However the fix looks correct to me.

mikke89 commented 3 months ago

Thanks for chiming in, I am happy with this change as it is then.

And thanks again for the fixup!