search

mikkeloscar / gopkgbuild

A golang package for parsing Arch Linux PKGBUILDs
GNU General Public License v3.0
22 stars 5 forks source link

Parsing too strict? #11

Closed Morganamilo closed 6 years ago

Morganamilo commented 6 years ago

The package qownnotes has armv7l in its arch array. I was going to make a pull request to add support for these arches but as far as I can tell it should be armv7l.

Currently parsing the SRCINFO for this package will fail because of the invalid arch. Is it fair to error because of that? makepkg --printsrcinfo doesn't care what arch you put in, it just does at it is told.

I think the parsing is a little too strict here and also with the version checking. causing #4 #10

I could make a pr that just removes the arch check completely but I'd rather run it by you first to see what you think.

Related: Jguer/yay#158

mikkeloscar commented 6 years ago

Yeah, lets drop the arch check since it's not so useful!

PR welcome!

Thanks!

mikkeloscar commented 6 years ago

Fixed in #13