search

mikkeloscar / gopkgbuild

A golang package for parsing Arch Linux PKGBUILDs
GNU General Public License v3.0
22 stars 5 forks source link

Stop execess emits of itemEndSplit #7

Closed Morganamilo closed 6 years ago

Morganamilo commented 6 years ago

Just noticed after the last pr it now emits itemEndSplit after every \n. This version looks good to me although you might want to take a proper look at it. I would suggest maybe extending the tests to test for specific output instead of just seeing if the parse passed or failed. Sorry for not catching this before the first pr.

mikkeloscar commented 6 years ago

Np, I also missed that. This looks correct to me though. If you want to add a check of the parsed values to the tests this would be much appreciated. Doesn't have to be in this PR though.

Morganamilo commented 6 years ago

I might get around to that eventually. Wont be this pr though.