search

mikkeloscar / pdb-controller

Controller for adding default Pod Disruption Budgets to Kubernetes Deployments and StatefulSets
Apache License 2.0
50 stars 10 forks source link

Update docker image :latest? #38

Open nicholasklem opened 4 years ago

nicholasklem commented 4 years ago

I noticed the docker image tagged :latest was not the latest on docker hub: https://hub.docker.com/r/mikkeloscar/pdb-controller/tags

Is 1 the current recommended docker image?

I made a Dockerfile to make images whenever master is updated:

FROM golang:alpine as builder
RUN apk add --update make git

# bust the cache when master is updated:
ADD https://api.github.com/repos/mikkeloscar/pdb-controller/git/refs/heads/master /version.json

RUN git clone https://github.com/mikkeloscar/pdb-controller.git /pdb-controller

WORKDIR /pdb-controller
ENV GO111MODULE=on
RUN make

FROM alpine
COPY --from=builder /version.json /pdb-controller/build/pdb-controller /
CMD ["/pdb-controller"]

Let me know when I can stop doing this and just pull :latest, :stable or something!

mikkeloscar commented 4 years ago

I have added docker push to #26 so when this is merged it will at least keep updating :latest.

vkobets commented 1 year ago

How can I help you with the docker image?

mikkeloscar commented 1 year ago

@vkobets with #49 the :latest image should not be available: mikkeloscar/pdb-controller:latest

If you want to have it e.g. based on tag you're welcome to contribute github action that can tag the image correctly.