Closed madogiwa0124 closed 2 years ago
I may need a bit more context for this one. What problem were you having that caused you to make this switch?
I see https://github.com/rails/rails/issues/25186 - and I know it's related to docker, but I just don't know enough to know. Are we missing a dev dependency (listen
)? Or are there any downsides to this approach?
@rickychilcott
Thanks for the comment!
I may need a bit more context for this one. What problem were you having that caused you to make this switch?
I created this PR because I couldn't start the dev environment due to its dependency on listen.
The reason for selecting ActiveSupport::FileUpdateChecker
is the intention of selecting the default value for Rails when listen is not used.
Are we missing a dev dependency (listen)?
I think adding the listen dependency is also the correct ❤️
Or are there any downsides to this approach?
There are concerns about performance degradation in the development environment, but Rails 7 defaults to using ActiveSupport::FileUpdateChecker
as an acceptable one.
Modern computers with SSDs don't see much/any benefit from having an evented file update watcher. https://github.com/rails/rails/pull/42985
If it seems better to add the listen dependency, I'll close this PR and create a new PR 😃
That all makes sense. No reason to add the extra dependency for minimal benefit (devs without SSDs). I'm all good on this one!
Thanks so much @madogiwa0124!
This is a PR to changed to
ActiveSupport::FileUpdateChecker
fromActiveSupport::EventedFileUpdateChecker
.How about this PR?
Description
The
ActiveSupport::EventedFileUpdateChecker
depends on listen, but since it is not installed, an exception is thrown when trying to start the development environment.Therefore, use
ActiveSupport::FileUpdateChecker
which does not depend on listen.Test
I was able to confirm that the boot succeeded on my local.