Add default flash notice on SessionsController#destroy

mikker / passwordless

🗝 Authentication for your Rails app without the icky-ness of passwords

MIT License

1.25k stars 86 forks source link

Add default flash notice on SessionsController#destroy #178

Closed lucianghinda closed 8 months ago

lucianghinda commented 8 months ago

What

This commit adds a default flash notice to destroy action while keeping the flexibility to customize redirect options via config.

Why

When creating a session in case of success, a flash notice is displayed, while when destroying a session, there was no flash notice displayed in case of success.

Also, having a successful flash message for destroying a session makes the system tests in the apps using this gem a bit easier to check if the logout happened successfully.

mikker commented 8 months ago

❤️🧡💛💚💙💜

yshmarov commented 8 months ago

heyy @lucianghinda nice to see you here! 🤗