Drop explicit I18n load path configuration

mikker / passwordless

🗝 Authentication for your Rails app without the icky-ness of passwords

MIT License

1.25k stars 86 forks source link

Drop explicit I18n load path configuration #221

Closed Dakota-Schramm closed 2 months ago

Dakota-Schramm commented 2 months ago

There is currently a problem with locales load order such that in production, passwordless locale files come after the application locale files in the I18n load path

This prevents the application from overriding any translations

Rails engines don't need to explicitly configure this at least since 5.1.4 (the current minimum requirement)

https://api.rubyonrails.org/v5.1.4/classes/Rails/Engine.html

Dakota-Schramm commented 2 months ago

We tested this in our own production specifically for the subject line and found that this change works

mikker commented 2 months ago

Great, thank you!

Must be a leftover from way back when.