mikker / passwordless

🗝 Authentication for your Rails app without the icky-ness of passwords
MIT License
1.28k stars 89 forks source link

Save session.id in session (cont.) #56

Closed mikker closed 5 years ago

mikker commented 5 years ago

Continued from https://github.com/mikker/passwordless/pull/53

mikker commented 5 years ago

@JoeSouthan I wanted to bring this home. WDYT? I felt like providing an upgrade helper was a nice thing to do that might help with adoption (and I wanted it myself too.)

JoeSouthan commented 5 years ago

Hey @mikker, apologies for the delay.

I've had a look through the changes and the upgrade helper was a good call. If you're happy with the changes it LGTM :+1: