mikker / passwordless

🗝 Authentication for your Rails app without the icky-ness of passwords
MIT License
1.28k stars 88 forks source link

Allow to config parent mailer #78

Closed Uysim closed 4 years ago

Uysim commented 4 years ago

if we do like this

Password.setup do |config|
   config.parent_mailer = "Application"
end

And our mailer inherit from that parent_mailer So we can allow user to custom options and layout by their base on rails config We can also remove this remove this Passwordless.default_from_address = "CHANGE_ME@example.com"

It got this concept from devise. If you are ok I can help

mikker commented 4 years ago

This sounds like an okay approach. PR welcome.

We'll need to support both ways until next major (1.0) so no need to pull out the current approach in you PR 😊

mikker commented 4 years ago

Closed in #82