search

mikker / passwordless

🗝 Authentication for your Rails app without the icky-ness of passwords
MIT License
1.26k stars 87 forks source link

mailer: allow configuration option to change the Mailer's superclass #82

Closed paulRbr closed 4 years ago

paulRbr commented 4 years ago

This PR adds a parent_mailer configuration option to the Engine which can receive a Mailer class from which the passwordless mailer will inherit from.

By default the Mailer inherits from ACtionMailer::Base but allowing the superclass to be configurable gives users the possibility to inherit from their own ApplicationMailer class for instance.

This is handy to be able to share users' mailer configuration between all mailers (including the own provided by Passwordless engine).

About #78. These changes are directly inspired by Devise.

mikker commented 4 years ago

I'm on board with this 👍 Can you add a note to the changelog about the change?

paulRbr commented 4 years ago

I'm on board with this +1 Can you add a note to the changelog about the change?

Sure! It's done ✓. Let me know if you need anything else.

paulRbr commented 4 years ago

@mikker any news to get this PR merged in? Do you need something more from me?

mikker commented 4 years ago

Looks good, sorry. Blame hectic quarantine days.

mikker commented 4 years ago

💙💚💛💜❤️

paulRbr commented 4 years ago

Haha, no worries.

Thanks for the review!

🤗 💛💚💙🖤

Em 30 de abril de 2020 22:34:14 GMT+02:00, Mikkel Malmberg notifications@github.com escreveu:

💙💚💛💜❤️>

-- > You are receiving this because you authored the thread.> Reply to this email directly or view it on GitHub:> https://github.com/mikker/passwordless/pull/82#issuecomment-622095096