mikkopaderes / ember-cloud-firestore-adapter

Unofficial Ember Data Adapter and Serializer for Cloud Firestore
MIT License
69 stars 17 forks source link

chore: fix all test scenarios, drop 3.24 (old) #283

Closed charlesfries closed 6 months ago

charlesfries commented 7 months ago

I am trying to submit some PRs to get this addon in a state that will let us easily upgrade to the latest EmberData at some point in the future.

The PR focuses on making all tests pass. Packages are updated to their minimum version that will meet that goal.

Fix EmberData types

Update some of the copy/pasted internal EmberData types to fix the floating dependency scenario.

Update ttypescript

Fix getter assignment error: Cannot set property constructor of [object Object] which has only a getter

Update ember-try

Fix dependency tree error related to @ember/test-helpers and ember-source

Update ember-data

Update EmberData to 4.11 to fix multiple @ember/error runtime errors: Could not find module @ember/error imported from @ember-data/store/-private

[Breaking] Drop Ember 3.24

Updating EmberData introduces a native array error that only occurs on 3.24. My choice was to simply drop 3.24 support but I'm curious what we think about this.

Install @ember/string

Fix runtime error: Could not find module @ember/string imported from ember-resolver/resolvers/classic/index

Update ember-simple-auth to v6

Fix runtime error: Could not find module @ember/polyfills imported from ember-simple-auth/utils/assign

https://github.com/mainmatter/ember-simple-auth/issues/2577

Uninstall ember-export-application-global

Fix runtime error: Cannot read properties of undefined (reading 'classify')

This addon is deprecated and the functionality it provides has been unadvised for a while.

Fix embroider test scenarios

There is an open issue in ember-cli-fastboot that prevents the embroider optimized scenario from succeeding. Adding staticEmberSource to the test app embroider config fixes the issue. Shouldn't be an issue as this is only related to testing.

https://github.com/ember-fastboot/ember-cli-fastboot/issues/925