search

mikkopaderes / ember-firebase-service

Exposes a service that's a direct representation of Firebase
MIT License
4 stars 2 forks source link

Fix import convention and unable to resolve service #37

Closed mikkopaderes closed 3 years ago

mikkopaderes commented 3 years ago

Firebase recommends imports to be of

import firebase from 'firebase/app';

The vendor-shim has been updated to adhere to that convention. This means that this may cause breakages to anyone using

import firebase from 'firebase';

Lastly, this PR fixes the service resolution:

@service firebase; // previously, only this type of service injection works
@service('firebase') firebaseService; // after pr merge, this now works too