mikldk / roxytest

Inline testthat tests with roxygen2
95 stars 3 forks source link

param_roclet checks @title by mistake? #17

Closed DataStrategist closed 4 years ago

DataStrategist commented 4 years ago

If I include param_rocklet in my DESCRIPTION package, it seems to give me a ton of warnings on the @title roxygen string rather than sticking to @param. Not sure if this is a bug.

image

My session:

R version 3.6.3 (2020-02-29)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=English_United Kingdom.1252 
[2] LC_CTYPE=English_United Kingdom.1252   
[3] LC_MONETARY=English_United Kingdom.1252
[4] LC_NUMERIC=C                           
[5] LC_TIME=English_United Kingdom.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets 
[6] methods   base     

other attached packages:
 [1] amitFuncs_0.24  forcats_0.3.0   stringr_1.4.0  
 [4] dplyr_0.8.5     purrr_0.3.4     readr_1.3.1    
 [7] tidyr_1.0.2     tibble_3.0.1    ggplot2_3.3.1  
[10] tidyverse_1.2.1

loaded via a namespace (and not attached):
 [1] tidyselect_1.0.0  xfun_0.14         haven_1.1.1      
 [4] lattice_0.20-38   colorspace_1.4-1  vctrs_0.3.1      
 [7] generics_0.0.2    testthat_2.3.2    rlang_0.4.6      
[10] pkgbuild_1.0.8    pillar_1.4.4      glue_1.4.1       
[13] withr_2.2.0       modelr_0.1.1      readxl_1.3.1     
[16] lifecycle_0.2.0   munsell_0.5.0     gtable_0.3.0     
[19] cellranger_1.1.0  rvest_0.3.5       knitr_1.28       
[22] callr_3.4.3       ps_1.3.3          fansi_0.4.1      
[25] broom_0.5.2       Rcpp_1.0.4.6      scales_1.1.1     
[28] backports_1.1.8   desc_1.2.0        pkgload_1.1.0    
[31] jsonlite_1.6.1    digest_0.6.25     hms_0.5.3        
[34] packrat_0.5.0     stringi_1.4.6     processx_3.4.2   
[37] grid_3.6.3        rprojroot_1.3-2   roxytest_0.0.1   
[40] cli_2.0.2         tools_3.6.3       magrittr_1.5     
[43] crayon_1.3.4      pkgconfig_2.0.3   ellipsis_0.3.1   
[46] prettyunits_1.1.1 xml2_1.3.2        lubridate_1.7.4  
[49] assertthat_0.2.1  httr_1.4.1        roxygen2_7.1.0   
[52] rstudioapi_0.11   R6_2.4.1          nlme_3.1-144     
[55] compiler_3.6.3  
DataStrategist commented 4 years ago

This is for https://github.com/DataStrategist/amitFuncs/ btw, in case you want to try

mikldk commented 4 years ago

Thanks for reporting. I will have a look.

mikldk commented 4 years ago

@DataStrategist : Can you please verify that 238f26d fixes the bug?

DataStrategist commented 4 years ago

Yes sir, it does! Thank you! It also seems to work now w/ devtools::document don't know if you did that now or if it was just something you did in the meantime, but that's coo! Good job

mikldk commented 4 years ago

Good to hear. Thank you for reporting!

DataStrategist commented 2 years ago

Hey @mikldk sorry, I guess this bug is back? Just updated everything to 4.2, Rtools 42 and all libraries installed from scratch, but still getting this:

Functions with @param inconsistency:
  * Function 'install_matplotlib()' with title 'install python library matplotlib': 
  * Function 'sankey()' with title 'create sankey visual': 

for this library. Why does this only happen to me? :D

mikldk commented 2 years ago

@DataStrategist Thanks for reporting (again). Are you sure that you have the latest version of roxytest?

DataStrategist commented 2 years ago

For some reason it had installed the cran version! I confirm that in this latest dev version it's correct.

mikldk commented 2 years ago

@DataStrategist Perfect, thanks. I should probably soon update CRAN (after resolving another issue).

DataStrategist commented 2 years ago

Thanks for supporting this still after so long!