search

mikofski / JGit4MATLAB

JGit wrapper for MATLAB
https://mikofski.github.io/JGit4MATLAB
BSD 2-Clause "Simplified" License
5 stars 3 forks source link

Latest version of jgit doesn't match regexp. #23

Open MikeChuckRoast opened 6 years ago

MikeChuckRoast commented 6 years ago

Regexp only expecting one digit for first 3 positions; but latest version is at 4.11; i.e. 2 digits in the second location. Additionally, the logic to provide an error about the version format also fails because version is empty (there is no version{1}).

Code changes: ver = '[0-9].[0-9]{1,2}.[0-9].[0-9]{12}'; % regex for version number version = regexp(tokens{1}{1},ver,'match','once'); % version

Also change instances of version{1} to version.

I can issue a pull request if desired.

mikofski commented 6 years ago

A PR would be great. Thanks for your feedback. FYI: I haven't used MATLAB or maintained this repository for a few years now. So feel free to make any other changes, and I'll pull them in too

MikeChuckRoast commented 6 years ago

How open are you to changes? I've been working on more extensive changes in my own fork. Matlab now includes jgit as part of the installation as it is used for Matlab's own GIT integration. I also couldn't get your SSH handler to work, but it doesn't seem like I have to: built in SSH works too, so I've removed that code.

Anyway, did you give me access to the repo? I don't think I can issue a pull request until I have permission to make my own branch. Or I don't know what I'm doing (very possible...I'm new to GIT).

mikofski commented 6 years ago

You should be able to fork this repo to your personal GitHub profile, clone it, branch it, make changes to your own fork's branch, and then submit a PR from there. See this tutorial I gave at UCBIDS for a step by step with links to GitHub's help docs.

Alternately, I could just transfer this entire repository over to you, not sure what will happen if you already have a fork tho.

Another alternate, if you can't get forking to work, is that I could add you as a contributor with write level access, and you could push directly to it, while not ideal, I am open to that option if it expedites your contribution.

So just tell me whatever works for you. I'm pretty much open to anything, so you can practically consider this your project if you want.