Move _SixMetaPathImporter to using find_spec()

mikolmogorov / Flye

De novo assembler for single molecule sequencing reads using repeat graphs

Other

769 stars 165 forks source link

Move _SixMetaPathImporter to using find_spec() #670

Closed pushkarnk closed 1 month ago

pushkarnk commented 8 months ago

Python 3.12 seems to have completely done away with find_module(), which the _SixMetaPathImporter still uses. This commit added support for 3.12 through the find_spec() finder approach.

Credits: This delta was borrowed from kafka-python project https://github.com/dpkp/kafka-python/blob/master/kafka/vendor/six.py

mikolmogorov commented 7 months ago

Thanks! I think I'd just drop support of Python2 for good in the next release..

pushkarnk commented 7 months ago

Makes sense. I'll withdraw this PR then. Thank you.

mikolmogorov commented 1 month ago

I guess in the meantime let's use this fix :)