search

mikolmogorov / Ragout

Chromosome-level scaffolding using multiple references
Other
146 stars 27 forks source link

Proposed fix for networkx removed function #66

Closed pmoulos closed 4 years ago

pmoulos commented 4 years ago

A proposed fix for #51

mikolmogorov commented 4 years ago

Thanks - does this solution support networkx 2.2 as well? Have you tested it with both Py 2 and 3?

pmoulos commented 4 years ago

Hi @fenderglass, I didn't change requirements.txt so it works with networkx 2.2. Also just tested with Python 3 and it works.

mikolmogorov commented 4 years ago

Because the API has changed between 2.2 and 2.3 (connected_components_subgraphs -> connected_components), I suspect 2.2 support might be broken. The fix needs to be tested with networkx 2.2 (and networkx 2.3) environments separately to ensure that both are working.

pmoulos commented 4 years ago

Checked with networkx 2.2, 2.3 and 2.4 - seems to be working.

mikolmogorov commented 4 years ago

Thanks a lot, merged!