mikonvergence / ControlNetInpaint

Inpaint images with ControlNet
MIT License
344 stars 29 forks source link

Updated ControlNet-with-Inpaint-Demo-colab.ipynb with diffusers==0.29.0 and changed HEDdetector pretrained model #23

Closed SahilCarterr closed 4 months ago

SahilCarterr commented 5 months ago

PR for Updated ControlNet-with-Inpaint-Demo.colab.ipynb

Description:

This pull request updates the ControlNet-with-Inpaint-Demo.colab.ipynb notebook with the following changes:

Detailed changes:

!pip install diffusers==0.29.0
hed_detector = HEDdetector.from_pretrained("lllyasviel/Annotators") 

Testing:

I have tested these changes locally and the notebook runs successfully Notebook with images here

Please review these changes and merge them if approved.

Thanks,

mikonvergence commented 5 months ago

Hi @SahilCarterr - thanks for the update, good work!

A few comments:

SahilCarterr commented 5 months ago

Hello @mikonvergence i have updated the ControlNet-with-Inpaint-Demo.ipynb to run on local machine and fixed import errors in ControlNet-with-Inpaint-Demo-colab.ipynb

SahilCarterr commented 4 months ago

@mikonvergence

mikonvergence commented 4 months ago

Hi, this repo contains a custom solution for StableDiffusionControlNetInpaintPipeline that was created and published before a similar solution was incorporated into diffusers. For the sake of the record, and the fact that the implementations are somewhat different, I never deleted the repo and its purpose is still the same, which is an independent implementation of the pipeline.

Hence, importing the object from the main library defeats the whole purpose of this repo:

from diffusers import StableDiffusionControlNetInpaintPipeline  ####changed-----

I cannot merge if the changes simply bypass the entire source code in src/, sorry! Thanks for the input!