search

mikro-orm / nestjs

NestJS MikroORM integration
MIT License
205 stars 31 forks source link

failing npm audit fix caused to dependency conflict #39

Closed tofixx closed 3 years ago

tofixx commented 3 years ago

Describe the bug I receive a peer dependency conflict with nestjs@8 and mikroorm/nestjs@4.3.0 when calling npm audit fix.

Stack trace

 % npm audit fix
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @mikro-orm/nestjs@4.3.0
npm ERR! Found: @nestjs/core@8.1.1
npm ERR! node_modules/@nestjs/core
npm ERR!   @nestjs/core@"^8.0.9" from the root project
npm ERR!   peer @nestjs/core@"^7.0.0||^8.0.0" from @mikro-orm/nestjs@4.3.0
npm ERR!   node_modules/@mikro-orm/nestjs
npm ERR!     @mikro-orm/nestjs@"^4.3.0" from the root project
npm ERR!   5 more (@nestjs/microservices, @nestjs/platform-express, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @nestjs/core@"^7.0.0||^8.0.0" from @mikro-orm/nestjs@4.3.0
npm ERR! node_modules/@mikro-orm/nestjs
npm ERR!   @mikro-orm/nestjs@"^4.3.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @nestjs/core@7.6.18
npm ERR! node_modules/@nestjs/core
npm ERR!   peer @nestjs/core@"^7.0.0||^8.0.0" from @mikro-orm/nestjs@4.3.0
npm ERR!   node_modules/@mikro-orm/nestjs
npm ERR!     @mikro-orm/nestjs@"^4.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See .../.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     .../.npm/_logs/2021-10-21T09_18_54_823Z-debug.log

To Reproduce Steps to reproduce the behavior: The execution happened within of the project https://github.com/hpi-schul-cloud/schulcloud-server/tree/765c1f3a632ae2c539575ab4d9d061898c0d96e9

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

Versions

| Dependency | Version | | npm | 8 | | node | 16 | | mikro-orm/nestjs | 4.3.0 | | nestjs/core | 8.1.1 or 8.0.9 |

B4nan commented 3 years ago

It's caused by other package, not mikro orm. Namely (based on your lock file) it is @golevelup/nestjs-rabbitmq that depends on the old nest version (v7.6.18), while you are trying to use v8.